From d101a0807c1eb321d37c4ebf6e81f5096f8669e3 Mon Sep 17 00:00:00 2001 From: Gunther6070 Date: Mon, 7 Apr 2025 14:06:34 -0400 Subject: Added backend check for empty name field --- .../src/main/java/com/ufund/api/ufundapi/service/CupboardService.java | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'ufund-api') diff --git a/ufund-api/src/main/java/com/ufund/api/ufundapi/service/CupboardService.java b/ufund-api/src/main/java/com/ufund/api/ufundapi/service/CupboardService.java index 859194a..33b272b 100644 --- a/ufund-api/src/main/java/com/ufund/api/ufundapi/service/CupboardService.java +++ b/ufund-api/src/main/java/com/ufund/api/ufundapi/service/CupboardService.java @@ -41,6 +41,8 @@ public class CupboardService { throw new IllegalArgumentException("Max Goal must be greater than zero"); } else if (goalType.equals(Need.GoalType.PHYSICAL) && maxGoal % 1 != 0) { throw new IllegalArgumentException("Cannot have non whole number value for physical goal"); + } else if (name == null || name.isEmpty()) { + throw new IllegalArgumentException("Required fields cannot be blank"); } for (Need searchNeed : cupboardDAO.getNeeds()) { @@ -103,6 +105,8 @@ public class CupboardService { throw new IllegalArgumentException("Goal must be greater than 0"); } else if (need.getType().equals(Need.GoalType.PHYSICAL) && need.getMaxGoal() % 1 != 0) { throw new IllegalArgumentException("Cannot have non whole number value for physical goal"); + } else if (need.getName() == null || need.getName().isEmpty()) { + throw new IllegalArgumentException("Required fields cannot be blank"); } return cupboardDAO.updateNeed(need); } -- cgit v1.2.3 From 7635188ed6182a72facd8ab3299f13c7217a8abd Mon Sep 17 00:00:00 2001 From: Gunther6070 Date: Mon, 7 Apr 2025 14:19:29 -0400 Subject: Added check for empty maxgoal field --- .../com/ufund/api/ufundapi/controller/CupboardController.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'ufund-api') diff --git a/ufund-api/src/main/java/com/ufund/api/ufundapi/controller/CupboardController.java b/ufund-api/src/main/java/com/ufund/api/ufundapi/controller/CupboardController.java index 5452c81..889abc5 100644 --- a/ufund-api/src/main/java/com/ufund/api/ufundapi/controller/CupboardController.java +++ b/ufund-api/src/main/java/com/ufund/api/ufundapi/controller/CupboardController.java @@ -58,7 +58,15 @@ public class CupboardController { String name = (String) params.get("name"); String image = (String) params.get("image"); String location = (String) params.get("location"); - double maxGoal = ((Number) params.get("maxGoal")).doubleValue(); + + double maxGoal; + try { + maxGoal = ((Number) params.get("maxGoal")).doubleValue(); + } catch (NullPointerException ex) { + LOG.log(Level.WARNING, ex.getLocalizedMessage()); + return new ResponseEntity<>("Required fields cannot be blank", HttpStatus.BAD_REQUEST); + } + boolean urgent = (Boolean) params.get("urgent"); String description = (String) params.get("description"); Need.GoalType goalType = GoalType.valueOf((String) params.get("type")); -- cgit v1.2.3