Created Cupboard Service and refactored the controller and DAO to add the service as an inbetween with logic

2 files changed, 4 insertions, 34 deletions

diff --git a/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardDAO.java b/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardDAO.java
index 1435410..6baf3e4 100644
--- a/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardDAO.java
+++ b/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardDAO.java
@@ -1,9 +1,9 @@
 package com.ufund.api.ufundapi.persistence;
 
-import com.ufund.api.ufundapi.model.Need;
-
 import java.io.IOException;
 
+import com.ufund.api.ufundapi.model.Need;
+
 /**
  * Defines the interface for Need object persistence
  * 
@@ -20,17 +20,6 @@ public interface CupboardDAO {
     Need[] getNeeds() throws IOException;
 
     /**
-     * Finds all {@linkplain Need needs} whose name contains the given text
-     * 
-     * @param targetName The text to match against
-     * 
-     * @return An array of {@link Need needs} whose names contains the given text, may be empty
-     * 
-     * @throws IOException if an issue with underlying storage
-     */
-    Need[] findNeeds(String targetName) throws IOException;
-
-    /**
      * Retrieves a {@linkplain Need need} with the given name
      * 
      * @param id The ID of the {@link Need need} to get
@@ -54,7 +43,7 @@ public interface CupboardDAO {
      * 
      * @throws IOException if an issue with underlying storage
      */
-    Need createNeed(Need need) throws IOException;
+    Need addNeed(Need need) throws IOException;
 
     /**
      * Updates and saves a {@linkplain Need need}
diff --git a/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardFileDao.java b/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardFileDao.java
index 81ee7c0..84ea693 100644
--- a/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardFileDao.java
+++ b/ufund-api/src/main/java/com/ufund/api/ufundapi/persistence/CupboardFileDao.java
@@ -61,18 +61,6 @@ public class CupboardFileDao implements CupboardDAO {
     }
 
     /**
-     * Returns an array of needs filtered by a search
-     *
-     * @param search The search substring
-     * @return The requested array
-     */
-    private Need[] getNeedsArray(String search) {
-        return needs.values().stream()
-                .filter(i -> i.getName().toLowerCase().contains(search.toLowerCase()))
-                .toArray(Need[]::new);
-    }
-
-    /**
      * Saves the needs to json
      *
      * @return True if the save was successful, false otherwise
@@ -93,13 +81,6 @@ public class CupboardFileDao implements CupboardDAO {
     }
 
     @Override
-    public Need[] findNeeds(String targetName) {
-        synchronized (needs) {
-            return getNeedsArray(targetName);
-        }
-    }
-
-    @Override
     public Need getNeed(int id) {
         synchronized (needs) {
             return needs.getOrDefault(id, null);
@@ -107,7 +88,7 @@ public class CupboardFileDao implements CupboardDAO {
     }
 
     @Override
-    public Need createNeed(Need need) throws IOException {
+    public Need addNeed(Need need) throws IOException {
         synchronized (needs) {
             Need newNeed = new Need(need);
             newNeed.setID(nextId());