Fix and clean up remaining tests

4 files changed, 22 insertions, 33 deletions

diff --git a/ufund-api/src/test/java/com/ufund/api/ufundapi/model/NeedTest.java b/ufund-api/src/test/java/com/ufund/api/ufundapi/model/NeedTest.java
index ffcd808..772af5c 100644
--- a/ufund-api/src/test/java/com/ufund/api/ufundapi/model/NeedTest.java
+++ b/ufund-api/src/test/java/com/ufund/api/ufundapi/model/NeedTest.java
@@ -48,15 +48,15 @@ public class NeedTest {
 
         double current = 0.00;
         need.setCurrent(current);
-        assertEquals(need.getCurrent(), current);
+        assertEquals(current, need.getCurrent());
 
         current = 100.00;
         need.setCurrent(current);
-        assertEquals(need.getCurrent(), current);
+        assertEquals(current, need.getCurrent());
 
         current = -100.00;
         need.setCurrent(current);
-        assertEquals(need.getCurrent(), current);
+        assertEquals(current, need.getCurrent());
 
     }
 
diff --git a/ufund-api/src/test/java/com/ufund/api/ufundapi/model/UserTest.java b/ufund-api/src/test/java/com/ufund/api/ufundapi/model/UserTest.java
index 22f6ffb..1725190 100644
--- a/ufund-api/src/test/java/com/ufund/api/ufundapi/model/UserTest.java
+++ b/ufund-api/src/test/java/com/ufund/api/ufundapi/model/UserTest.java
@@ -1,10 +1,10 @@
 package com.ufund.api.ufundapi.model;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.*;
+
 @Tag("Model-tier")
 public class UserTest {
 
@@ -70,7 +70,7 @@ public class UserTest {
 
         User user = new User(expectedName);
 
-        assertEquals(false, user.verifyPassword(expectedName));
+        assertFalse(user.verifyPassword(expectedName));
 
     }
 
diff --git a/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/CupboardFileDAOTest.java b/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/CupboardFileDAOTest.java
index e554f9d..cbfa30c 100644
--- a/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/CupboardFileDAOTest.java
+++ b/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/CupboardFileDAOTest.java
@@ -42,37 +42,25 @@ public class CupboardFileDAOTest {
     }
 
     @Test
-    public void GetNeedsTest() throws IOException {
+    public void getNeedsTest() {
         Need[] needs = cupboardFileDao.getNeeds();
         assertEquals(needs.length,testNeeds.length);
 		assertEquals(needs[0].getName(), testNeeds[0].getName());
     }
 
     @Test
-    public void GetNeedTest() throws IOException {
+    public void getNeedTest() {
 		Need need1 = cupboardFileDao.getNeed(0);
 	
 		assertEquals(testNeeds[0], need1);
     }
 
 	@Test
-    public void Fet() throws IOException {
-		String targetName1 = "one";
-		String targetName2 = "two";
-
-		Need need1 = cupboardFileDao.findNeeds(targetName1)[0];
-		Need need2 = cupboardFileDao.findNeeds(targetName2)[0];
-
-		assertEquals(testNeeds[0], need1);
-		assertEquals(testNeeds[1], need2);
-    }
-
-	@Test
-	public void CreateNeedTest() throws IOException {
+	public void createNeedTest() throws IOException {
 		Need newNeed = new Need("sea urchin hats", 3, 100, GoalType.PHYSICAL);
 		
 
-		Need actualNeed = cupboardFileDao.createNeed(newNeed);
+		Need actualNeed = cupboardFileDao.addNeed(newNeed);
 
 		assertNotNull(actualNeed);
 
@@ -80,7 +68,7 @@ public class CupboardFileDAOTest {
 	}
 
 	@Test
-	public void DeleteNeedTest() throws IOException {
+	public void deleteNeedTest() throws IOException {
 		Need undeletedNeed = cupboardFileDao.getNeed(0);
 		assertNotNull(undeletedNeed);
 
@@ -92,7 +80,7 @@ public class CupboardFileDAOTest {
 	}
 
 	@Test
-	public void UpdateNeedTest() throws IOException {
+	public void updateNeedTest() throws IOException {
 		Need[] needs = cupboardFileDao.getNeeds();
 		Need unupdatedNeed = needs[needs.length - 1];
 		assertNotNull(unupdatedNeed);
diff --git a/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/UserFileDAOTest.java b/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/UserFileDAOTest.java
index ba39130..b802669 100644
--- a/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/UserFileDAOTest.java
+++ b/ufund-api/src/test/java/com/ufund/api/ufundapi/persistence/UserFileDAOTest.java
@@ -40,7 +40,7 @@ public class UserFileDAOTest {
     }
 
     @Test
-    public void GetUsersTest() throws IOException {
+    public void getUsersTest() {
         User[] users = userFileDAO.getUsers();
 
         assertEquals(users.length,testUsers.length);
@@ -48,16 +48,17 @@ public class UserFileDAOTest {
         for (int i = 0; i < testUsers.length;++i) {
 			boolean isInArray = false;
             for (User user : testUsers) {
-				if (users[i].getUsername().equals(user.getUsername())) {
-					isInArray = true;
-				}
+                if (users[i].getUsername().equals(user.getUsername())) {
+                    isInArray = true;
+                    break;
+                }
 			}
 			assertTrue(isInArray);
 		}
     }
 
     @Test
-    public void FindUsersTest() throws IOException {
+    public void findUsersTest() {
 		User realUser1 = userFileDAO.getUser("bob");
 		User realUser2 = userFileDAO.getUser("admin");
 
@@ -66,14 +67,14 @@ public class UserFileDAOTest {
     }
 
 	@Test
-    public void FindUsersNullTest() throws IOException {
+    public void findUsersNullTest() {
 		User fakeUser = userFileDAO.getUser("phil.n.thropist");
 
 		assertNull(fakeUser);
     }
 
 	@Test
-	public void CreateUserTest() throws IOException {
+	public void createUserTest() throws IOException {
 		User newUser = new User("keshey");
 		userFileDAO.addUser(newUser);
 
@@ -84,7 +85,7 @@ public class UserFileDAOTest {
 	}
 
 	@Test
-	public void DeleteUserTest() throws IOException {
+	public void deleteUserTest() throws IOException {
 		User notDeletedUser = userFileDAO.getUser("jelly12");
 		assertNotNull(notDeletedUser);
 
@@ -96,7 +97,7 @@ public class UserFileDAOTest {
 	}
 
 	@Test
-	public void UpdateUserTest() throws IOException {
+	public void updateUserTest() throws IOException {
 		User toBeUpdatedUser = userFileDAO.getUser("admin");
 		assertNotNull(toBeUpdatedUser);